chore: remove pull_request_target and use two workflows#992
Open
Yu-Jack wants to merge 1 commit intoharvester:mainfrom
Open
chore: remove pull_request_target and use two workflows#992Yu-Jack wants to merge 1 commit intoharvester:mainfrom
Yu-Jack wants to merge 1 commit intoharvester:mainfrom
Conversation
github-actions
bot
requested review from
akashraj4261,
dariavladykina and
jillian-maroket
Yu-Jack
requested review from
Vicente-Cheng and
ihcsim
and removed request for
akashraj4261,
dariavladykina and
jillian-maroket
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the existing pull_request_target-based preview workflow with a two-workflow approach: a pull_request workflow that builds and uploads artifacts, and a workflow_run workflow that deploys and comments on the PR with elevated permissions.
Changes:
- Switch
.github/workflows/pull-request.ymlfrompull_request_targettopull_request, and move deployment/commenting out of the workflow. - Add
.github/workflows/pull-request-deploy.ymltriggered byworkflow_runto download artifacts, deploy to Netlify, and update the PR comment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/pull-request.yml |
Builds the PR and uploads build + PR metadata as artifacts for a follow-up workflow. |
.github/workflows/pull-request-deploy.yml |
On successful build completion, downloads artifacts, deploys to Netlify, and updates the PR comment with the preview link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Signed-off-by: Jack Yu <jack.yu@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This's for RST requirement to remove all pull_request_target. Use two steps workflows to achieve the goal with workflow event trigger.
Test result:
PR: Yu-Jack#12
Comment: Yu-Jack#12 (comment)